Use local document loader with vdlCtx #77
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi guys ( @PatStLouis @aljones15 @BigBlueHat ), can you take a look at this? |
Signed-off-by: ashushukla0412 <[email protected]>
BigBlueHat
force-pushed
the
use-vdl-document-loader
branch
from
43c403a to
79a0471
Compare
|
Thank you for submitting this @ashushukla0412! I'm focusing on bringing parts of it in gradually, as can be seen in #78. I'd love your feedback on that PR if you have a moment. Really appreciate the help, and apologies for the (very) slow response! |
|
Yeah, sure, I'd be happy to take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data Integrity bbs-2023 verifiers test case uses vdl context, which is not present in
defaultLoaderused byissueCloned(from data-integrity-test-suite repo) - this leads to test casebeforehook failing. So instead using localdocumentLoaderwhich has vdlCtx cached. Updatedcontexts.jswith required contexts.Related PRs: